decentraland / social-service-ea / 34996768204

91%

push

github

fix: return only memberships from the batch member communities endpoint (#498)

* fix: return only memberships from the batch member communities endpoint

POST /v1/members/:address/communities returned any active listed
community for the given address, whether or not the address had joined
it. Membership was only required for unlisted communities, so the
response mixed real memberships with communities that were merely
visible to the address.

Callers use this endpoint to resolve which communities an address
belongs to, so the query now inner joins community_members and only an
existing membership row qualifies a community. Listing and privacy are
no longer considered. The active community and ban exclusions are kept.

The method is renamed to getMemberCommunitiesByIds to match the
contract, and each returned community carries the role the address
holds in it, so callers do not have to infer membership from presence
in the list.

The OpenAPI description and response schema now state the membership
rules and document the role field. The integration spec covers joined
and not joined cases for public, private and unlisted communities,
mixed batches, roles, a different address, bans and the failure path.

* refactor: type the batch member communities role as CommunityMemberRole

CommunityRole.None denotes the absence of a membership and is never
stored in community_members, so the role returned for a membership can
only be owner, moderator or member. Introduce CommunityMemberRole as
CommunityRole without None and use it for the batch endpoint's database
method, component interface and response type, so the declared shape
matches the documented contract.

2589 of 2987 branches covered (86.68%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

6240 of 6692 relevant lines covered (93.25%)

93.32 hits per line