ruby-grape / grape / 34990187739

100%

push

github

Stop class-level reads from remounting the whole mount tree (#2946)

Fixes #2945. On 4.0, reading a class-level setting such as
`default_format`, `version` or `namespace` on an API with nested mounts
took seconds: 5131 `add_setup` calls for a three-level tree, where 3.3.5
makes one.

Every method of `Grape::API::Instance` not named in `NON_OVERRIDABLE` is
redefined on an API class to record a setup step, and a recorded step
other than `mount` refreshes each mount of that API. #2788 made that
refresh match mounted apps with `mounted.base.equal?(app.base)`, where
`app` is the API class as written, and `base` was not on the list. So
every comparison recorded a `base` step on the mounted API, which
refreshed that API's own mounts, which compared their apps' bases in
turn, all the way down the tree. The `to_s` it replaced is a `Class`
method and was never recorded.

`base` joins `NON_OVERRIDABLE` and is forwarded to the base instance,
which answers the API class itself.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1380 of 1429 branches covered (96.57%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

4156 of 4156 relevant lines covered (100.0%)

26947.25 hits per line