34981504641
100%

Ran 15 Sep 2026 02:28PM UTC

Jobs 1

Files 18

Run time 1min

Badge

Embed ▾

Committed 15 Sep 2026 02:25PM UTC coverage: 99.725%. Remained the same

Build # 34981504641

Build Type

push

github

Committed by

web-flow

Commit Message

fix: make the MnPrint bindings memory-safe (#1208)

:robot: _AI text below_ :robot:

Three problems in the `MnPrint` bindings. `MnPrint::Impl` indexed a
four-element label array with the verbosity level, but `Verbosity` has a
fifth level `Trace = 4`, which `MnLineSearch` and
`InitialGradientCalculator` emit; `Minuit(lambda x: (x - 1) ** 2, x=0)`
with `print_level = 4` read a garbage pointer and crashed. `PyMnPrint`
held an `MnPrint` member, whose constructor and destructor push and pop
a thread-local stack of raw prefix pointers, so out-of-order destruction
in Python (`a = MnPrint("AAA", 3); b = MnPrint("BBB", 3); del a`) made
`b.warn(...)` print the freed prefix of `a`. `show_prefix_stack`,
`add_filter`, and `clear_filter` are static C++ functions, but were
bound with `def`, so an instance call raised `TypeError`.

The fix adds the fifth label, stores only the prefix and level in
`PyMnPrint` and makes a local `MnPrint` for each message so the push and
pop stay nested, and binds the three static functions with `def_static`.
The Python API does not change. Regression tests are in
`tests/test_core.py`.

Part of #1192

Coverage Stats

3989 of 4000 relevant lines covered (99.73%)

1.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	34981504641.1	15 Sep 2026 02:28PM UTC	18	99.73	GitHub Action Run

scikit-hep / iminuit / 34981504641
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 34981504641

scikit-hep / iminuit / 34981504641 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 34981504641

scikit-hep / iminuit / 34981504641
100%

README BADGES
x