scikit-hep / iminuit / 34979213457

100%

push

github

fix: recompute total counts in BinnedNLL so in-place edits are visible (#1212)

Astra noticed this while reviewing #1176.

:robot: _AI text below_ :robot:

`BinnedNLL` cached the total number of counts in `_update_cache`
(#1149). In-place edits of `c.n[...]` on an unmasked histogram bypass
the cache, so the prediction stayed at the old total and a perfectly
matching cost became non-zero. The total is now computed from the live
counts in `_pred` and `_grad`. Adds a regression test.

3 of 3 new or added lines in 1 file covered. (100.0%)

3989 of 4000 relevant lines covered (99.73%)

1.0 hits per line