coreui / coreui-pro / 34976092055

96%

main: 94%

push

github

fix(Autocomplete): stop submitting the typeahead hint with the form (#1312)

With `showHints` on, the hint input behind the field carried a `name` and,
being readonly rather than disabled, was serialized with the form. With a
configured `name` it took the same one as the real input, and the hint comes
first in the markup, so `new FormData(form).getAll('tech')` returned
`['', 'Angular']` and anything reading the first value got an empty string.
Without one the hint still shipped a `<uid>-hint` key of its own, so no form
carrying a hint was clean either way.

The hint carries no `name` at all now. It is decorative: `aria-hidden`,
readonly, out of the tab order, and nothing in the component or the stylesheet
reads that attribute.

The migration guide gains an entry, because what the form submits changes on
upgrade: `form.elements[name]` is an input rather than a `RadioNodeList`, and
a page written as `getAll(name)[1]` has to read the plain value.

5688 of 6333 branches covered (89.82%)

Branch coverage included in aggregate %.

10981 of 11383 relevant lines covered (96.47%)

473.8 hits per line