HSF / phoenix / 34966708756

50%

master: 38%

push

github

fix(ui-components): cancel SSMode's deferred listener timer on destroy (#1035)

`toggleSSMode` defers attaching the document click/touchstart listeners by 1ms,
working around the activating click firing them immediately. The timer id was
never stored, so `ngOnDestroy` had no way to cancel it.

Destroying the component inside that window runs the removals first, while
nothing is attached yet, and the timer then attaches both listeners to a
component that no longer exists. Neither removal path can reach them
afterwards - `ngOnDestroy` has already run and the toggle-off branch is
unreachable - so they stay on `document` for the life of the page and every
later click calls `exitFullscreen()`.

MakePictureComponent carries the identical workaround and was hardened for
exactly this in ef594ae, from review feedback on #867. That fix covered one of
the two copies; this is the other.

Store the timer id and clear it in `ngOnDestroy`, and also when the user
toggles screenshot mode off while it is still pending. Mirrors make-picture so
the two stay in step.

Added tests covering that no listener is attached after destroy and that a
normal toggle still attaches both. The first fails before this change.

Fixes #1034

885 of 2131 branches covered (41.53%)

Branch coverage included in aggregate %.

3337 of 6503 relevant lines covered (51.31%)

203.87 hits per line