solidjs / solid / 34957255815

72%

main: 89%

push

github

test(signals): store oracle + four signal states; latest() seed leak and body-end visibility fixes (#3455)

* test(signals): store oracle + four signal states; fix latest() seed leak and body-end visibility

Oracle grows from 90 to 207 cells. The harness (cell vocabulary, readers,
hold management, runner) moves to tests/visibility-oracle.harness.ts,
shared by the signal oracle (now 14 states: + body ended, un-superseded,
held truth, loading window over a held input) and a new store oracle
(8 states through plain stores, optimistic stores and projections).

Two runtime fixes the new cells found:

- latest(() => store.key) on an unresolved projection returned the SEED.
  read() routes a latest() read to the companion before its firewall
  logic, and the leaf's own _value is the seed; latestRead now judges
  "uninitialized" on the leaf's owner (the firewall) and throws like
  every other read (A25, A7).

- The body-end supersession window (#3427) read differently from a
  landing supersession: a stale re-run showed the committed truth beside
  a display still showing the override, a fresh mainline memo published
  it, isPending read false while latest read the truth. One cause: an
  override written inside an action never passes the adoption loop that
  stamps _transition, and body-end stages nothing that would queue it, so
  the node carried no stamp. Ownership for an override node is
  _overrideOwner (#2912); supersededRead and the verdict resolve it now.
  Pinning that exposed a fourth: a latest() pull through supersededRead
  fell to enterStagedRead's initTransition path and captured the caller's
  block — verdict pulls are observations and never enter from mainline.

Rulings recorded: A27 (verdict-quiet is a hydration invariant; the
window's first real landing is initial-load class even over a held
input), A18 body-end visibility, A29 verdict-pull note, A7 owner-judged.
Also a type fix in born-held (bornHeld narrowed to never).

Signals 2005 / solid... (continued)

520 of 790 branches covered (65.82%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.1 hits per line