solidjs / solid / 34956004828

71%

main: 89%

push

github

perf(signals,web,universal,html): merge/omit are always lazy views; consumers read the leaves (#3454)

* perf(signals,web,universal,html): merge/omit are always lazy views; consumers read the leaves

merge() and omit() never copy under Proxy. omit() returns a view record for
every input (plain objects included, predicate filters supported); merge()
returns an O(1) view over its flattened sources, or the single non-function
source itself. omit-over-merge carries one filtered leaf view per source,
merge-over-omit takes the record as a leaf, nested omits fold their filters:
the headless-UI chain merge → omit → merge → omit collapses to leaf views over
the author's objects with no proxy layer between spread and props.

Reads: a view over plain leaves resolves a key → owning-leaf table on first
read (merged key order), after which get/has/descriptor are one lookup.
spread() (web, universal) and ssrElement() read leaves directly and walk the
table when present, so an effect rerun is one read per key as it was over
the eager copy. Views over a store, a memo source, or any `$PROXY in s`
proxy (frames slot props) keep the `in` walk.

Truthful descriptors: getOwnPropertyDescriptor through any depth reports a
data descriptor only for a data property of a plain leaf, an accessor for a
getter, store key, or memo source. hasStaticKeys() says when a key set is
fixed; spread() uses both to skip the children effect for static children
behind omit/merge layers (#3388 through views).

@solidjs/html built props by assigning onto merge()'s result; it now
collects its own props and merges once at the end (#3384).

Signals-layer chain (depth 1/3/7) vs next: build 7.4/29/131 µs → 2.2/6.4/19;
build+reads 8.3/31/95 → 2.5/7.4/20. SSR polymorphic-chain 200 rows ~2.4×
faster; DOM update path at parity.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* perf(signals): views identify stores through $TARGET, never a store's gen... (continued)

520 of 790 branches covered (65.82%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.1 hits per line