hyperledger / fabric-x-committer / 34933597226
91%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 139
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 90.422% (-0.3%) from 90.679%
34933597226

push

github

web-flow 
[test] Hold the stopped verifier's port during the outage (#820)

#### Type of change

- Test update

#### Description

- Reserve mock verifier 0's ports for the duration of the outage in
`TestSignatureVerifierManagerPolicyUpdateAndRecover`, so a parallel test
binary cannot bind them
while the server is down. The restart takes the reservation over via
`ServerConfig.Listener`.
- Promote `utils/connection`'s local `reserveWhileServerDown` to
`test.ReserveWhileServerDown` and
  use it from both call sites, rather than duplicating it.
- The new call replaces the `test.CheckServerStopped` assertion it
subsumes.

#### Additional details (Optional)

The test stops the server, spends ~4 s on further assertions, then
restarts it on the same ephemeral
port. Because `make test-no-db` runs the package binaries in parallel,
another binary can bind that
port meanwhile, and the verifier client — still dialing it — reaches a
foreign gRPC server that
answers `Unimplemented: unknown service servicepb.Verifier`.

That error is not joined with `retry.ErrBackOff`, so `retry.Sustain`
retries with no delay, and every
attempt records a `Connected` followed by a `Disconnected`, since
`StartStream` succeeds lazily
against any listener. The connection `FailureTotal` therefore climbed to
12,968 in the observed run,
failing the post-restart assertion that it is exactly 1.

With a reservation-only listener on the port, `StartStream` fails fast
and the client backs off, so
the counter stays at 1. Treating a server-returned `Unimplemented` as
backoff-worthy in
`sendTransactionsAndForwardStatus` would cap the damage of any similar
window in production too, but
that is a change to non-test code and is not needed to make this test
deterministic.

Verified with `-race`: the target test 2/2 and `-run
'^TestSignatureVerifierManager'` 3/3, plus
`TestGRPCRetry` 2/2 for the promoted helper. `make lint` passes.

#### Related issues

- resolves #819
- same family as #712, #738


🤖 Generated wi... (continued)

9478 of 10482 relevant lines covered (90.42%)

10809.03 hits per line

Coverage Regressions

Lines Coverage ∆ File
11
78.75
-2.54% service/sidecar/sidecar.go
6
83.11
-1.99% service/vc/database.go
4
84.73
-3.05% service/vc/committer.go
4
90.32
-2.15% service/vc/validator_committer_service.go
2
79.57
-2.15% service/query/query.go
2
97.22
-2.78% service/verifier/verifier_server.go
2
95.03
0.55% service/coordinator/signature_verifier_manager.go
2
93.37
-1.02% service/coordinator/coordinator.go
1
97.12
2.88% mock/coordinator.go
1
96.2
-1.27% mock/sigverifier.go
1
76.0
-2.0% utils/utils.go
Jobs
ID Job ID Ran Files Coverage
1 unit-test - 34933597226.1 94
85.79
GitHub Action Run
2 core-db-test - 34933597226.2 106
48.4
GitHub Action Run
3 db-test - 34933597226.3 139
78.68
GitHub Action Run
Source Files on build 34933597226