MapColonies / shigola / 88ddc1d84
57%
master: 44%

LAST BUILD BRANCH: chore/drop-vendor
DEFAULT BRANCH: master
Ran
Jobs 1
Files 126
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 55.662%. Remained the same
88ddc1d84

push

github

web-flow 
fix(ci): make the docker job build the image and check that it did (MAPCO-11501) (#27)

* fix(ci): make the docker job build the image and check that it did

"Build Docker Image" in on_pr_push.yml ran docker/build-push-action with no
checkout step and no `with:` block at all -- no context, no build args, no
tags, no push. Whatever it produced was untagged, unstamped, unloaded and
unpushed, and nothing asserted on it, so the job had no way to report anything
but success. It was added in #1 and never finished.

It now checks the tree out, builds from it with `context: .`, and loads the
result. Build args come from the commit under test, so the image is stamped
rather than reporting "Version Not Set".

The assertion is the part that makes the job mean anything. `shigola version`
exits 0 whether or not the stamp took, so a step that merely runs it passes
against an unstamped image -- the same silence MAPCO-11500 found in the release
job. This one greps for the short SHA it built with, so an image that is not
this commit's fails.

It builds and never pushes: publishing belongs to on_release_publish.yml, which
keeps it.

Verified against this tree: the good build reports "version: 3002e2a / git:
fix/ci-docker-build-job @ 3002e2a" and the assertion passes; an image built
without build args reports "Version Not Set" and the assertion fails; a bad RUN
in the Dockerfile and a Go compile error each exit 1.

The trigger comment on on_release_publish.yml also now records what that
workflow does NOT do, which is easy to read the opposite way: its push trigger
is `master`, `development` is the trunk, so nothing fires on a merge to trunk
and `edge` is effectively unpublished. Which branch publishes edge is
MAPCO-11500's call, not this ticket's.

MAPCO-11501

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HPwZrZ2WCwXU1auVnFR4CH

* test(build): fail a docker build job that does not check the tree out
... (continued)

5810 of 10438 relevant lines covered (55.66%)

122.86 hits per line

Jobs
ID Job ID Ran Files Coverage
1 88ddc1d84.1 126
55.66
GitHub Action Run
Source Files on build 88ddc1d84