MapColonies / shigola / aea18cdae
57%
master: 44%

LAST BUILD BRANCH: chore/drop-vendor
DEFAULT BRANCH: master
Ran
Jobs 2
Files 126
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 55.662%. Remained the same
aea18cdae

push

github

web-flow 
fix(ci): stamp release images with a real version and publish them to our registry (MAPCO-11500) (#26)

* fix(build): stamp the version into the correctly-cased package path

The Dockerfile's BUILDPKG named github.com/mapcolonies/shigola/internal/build,
but the module is github.com/MapColonies/shigola. Go import paths are
case-sensitive, so that is a different package, and the linker silently
discards an -X whose symbol does not resolve. Every image built from the ARG
default therefore reported "version not set" with no build, test or publish
step failing anywhere along the way.

Confirmed by building both ways: with the old path the image reports
"version not set / not set @ not set", with the corrected one it reports the
version, branch and revision it was given. Both builds succeed, which is the
whole problem.

The build directory is respelled to match. It is only a filesystem path and
its case never mattered -- the build is in module mode -- but leaving it
lower-cased beside the corrected ARG invites someone to "fix" the ARG back.

Adds internal/build.TestStampPathMatchesModulePath, which reads the tree and
checks every stamp path against the module path in go.mod. This has to be a
file-reading test: a stamp path lives in a Dockerfile or a workflow, never in
a Go import the compiler could verify, so building the tree cannot see it. It
is deliberately broader than the case bug, failing on any stamp path that is
not exactly the module path plus /internal/build -- including one still
naming the upstream project. TestStampedSymbolsExist covers the other half of
the same silence, a stamp into a variable that has been renamed.

Also adds the missing trailing newline.

MAPCO-11500

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FAuBtQoVu1QfxpWUvCo7Ap

* fix(ci): publish release images to MapColonies' ACR with real build args

Three defects in the one job, none of which failed a build.

... (continued)

5810 of 10438 relevant lines covered (55.66%)

245.72 hits per line

Jobs
ID Job ID Ran Files Coverage
1 aea18cdae.1 126
55.66
GitHub Action Run
2 aea18cdae.2 126
55.66
GitHub Action Run
Source Files on build aea18cdae