tarantool / go-tarantool / 34838107393

77%

master: 76%

Build Type

Pull #605

github

Committed by bigbes

Commit Message

future: make Release() of an unfinished future a no-op

Release() zeroed the object and returned it to futurePool without
checking that the request had completed. The documented lifecycle is
Do -> Get -> Release, but the natural fire-and-forget reading
`fut := conn.Do(req); fut.Release()` recycled a node that was still
linked into the connection's list of pending requests. Request ids are
never 0, so the zeroed node truncated the list for findFuture() and
clear(): the response was never matched back, markDone() never ran for
it, requestCnt never dropped (so CloseGraceful() hung) and with
Opts.Timeout == 0 the owners of the futures behind it blocked forever.
The recycled node could also be linked into a second list through the
pool.

Return early when the future is not finished, leaving the object to the
garbage collector, and document the precondition on Future.Release(), on
the implementation and in the migration guide. NewFutureWithErr() and
NewFutureWithResponse() return already finished futures, so they are
unaffected.

Pull Request Pull Request #605: future: make Release() of an unfinished future a no-op

Coverage Stats

20 of 23 new or added lines in 2 files covered. (86.96%)

3 existing lines in 1 file now uncovered.

3210 of 4179 relevant lines covered (76.81%)

97519.84 hits per line