tarantool / go-tarantool
75%
master: 76%

LAST BUILD BRANCH: bigbes/gh-238-request-value-receivers
DEFAULT BRANCH: master
Repo Added
Files 19
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH bigbes/gh-238-request-value-receivers
branch: SELECT
CHANGE BRANCH
x

coverage: 75.285% (-0.2%) from 75.484%
26332951575

Pull #584

github

bigbes 
request: switch all request types to value receivers and value returns

All New*Request() constructors now return values instead of pointers. All
methods on request types use value receivers and return values, enabling
immutable builder-style chaining.

Renamed all value constructors from Make* to New* for naming consistency
across the connector: crud.Make*Request → crud.New*Request,
datetime.MakeDatetime → datetime.NewDatetime, decimal.MakeDecimal /
MakeDecimalFromString / MustMakeDecimal → decimal.NewDecimal /
NewDecimalFromString / MustNewDecimal, arrow.MakeArrow → arrow.NewArrow,
crud.MakeResult → crud.NewResult.

Removed intermediate spaceRequest, spaceIndexRequest types from the
tarantool package and spaceRequest from the crud package — space and
index fields are inlined directly into each request struct.

Converted all constructors to composite literal style.

Applied the same pattern to arrow/ and settings/ packages.

In the box/ subpackage, request types no longer embed
tarantool.CallRequest. They store it as a private field via
baseCallRequest and implement their own Context() method returning the
wrapper type.

Part of #238
Pull Request #584: request: switch all request types to value receivers and value returns

183 of 183 new or added lines in 5 files covered. (100.0%)

7 existing lines in 1 file now uncovered.

3107 of 4127 relevant lines covered (75.28%)

9970.65 hits per line

Relevant lines Covered
4127 RELEVANT LINES 3107 COVERED LINES
9970.65 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
26332951575 bigbes/gh-238-request-value-receivers request: switch all request types to value receivers and value returns All New*Request() constructors now return values instead of pointers. All methods on request types use value receivers and return values, enabling immutable builder-style chai... Pull #584 bigbes github
75.28
25956710055 bigbes/gh-238-request-value-receivers request: switch all request types to value receivers and value returns All New*Request()/Make*Request() constructors now return values instead of pointers. All methods on request types use value receivers and return values, enabling immutable bui... Pull #584 oleg-jukovec github
75.33
25917210927 master tests: capture tarantool log tail in startup errors When StartTarantool fails, the returned error gives only the connection or exit reason ("exit status 1", "context deadline exceeded"), so a CI failure required re-running the test locally to see... push oleg-jukovec github
75.58
25917220948 master api: unexport Stream fields Make Stream.Id and Stream.Conn unexported, turning Stream into an opaque handle. This enforces encapsulation and prevents unsafe direct mutation (e.g. stream.Conn = nil). Neither the stream identifier nor the underlyin... push oleg-jukovec github
75.48
25916043972 bigbes/gh-147-capture-tarantool-log-tail tests: capture tarantool log tail in startup errors When StartTarantool fails, the returned error gives only the connection or exit reason ("exit status 1", "context deadline exceeded"), so a CI failure required re-running the test locally to see... Pull #587 bigbes github
75.44
25915441139 bigbes/gh-147-capture-tarantool-log-tail tests: capture tarantool log tail in startup errors When StartTarantool fails, the returned error gives only the connection or exit reason ("exit status 1", "context deadline exceeded"), so a CI failure required re-running the test locally to see... Pull #587 oleg-jukovec github
75.31
25767043469 bigbes/gh-471-unexport-stream-fields api: unexport Stream fields Make Stream.Id and Stream.Conn unexported, turning Stream into an opaque handle. This enforces encapsulation and prevents unsafe direct mutation (e.g. stream.Conn = nil). Neither the stream identifier nor the underlyin... Pull #588 bigbes github
75.39
25766361615 bigbes/gh-147-capture-tarantool-log-tail tests: capture tarantool log tail in startup errors When StartTarantool fails, the returned error gives only the connection or exit reason ("exit status 1", "context deadline exceeded"), so a CI failure required re-running the test locally to see... Pull #587 bigbes github
75.46
25766361465 bigbes/gh-no-rewrite-pool-new pool: bound New connect by context, add WaitConnected pool.New / pool.NewWithOpts no longer use Opts.CheckTimeout to bound the initial connect: they dial all instances concurrently and wait for those dials to finish, bounded only by the supplied ... Pull #592 bigbes github
75.58
25404692616 master tests: prevent leaked tarantool on bad start Two related issues from #147 made test failures painful to diagnose: 1. When a test panicked, the spawned tarantool process was left running and kept its TCP port bound, so the next run failed with... push oleg-jukovec github
75.44
See All Builds (2340)