tarantool / go-tarantool / 34838107314

77%

master: 76%

Build Type

Pull #603

github

Committed by bigbes

Commit Message

connection: fix data race between two reader goroutines

conn.lenbuf and conn.dec were per-Connection fields, but two reader
goroutines of the same Connection can be alive at the same time. When the
writer goroutine hits an I/O error it calls reconnect(), which closes the
current Conn and dials a new one under conn.mutex, starting a fresh
reader. The old reader is not stopped by that: it keeps consuming the data
already buffered by the previous connection and only leaves its loop on
connClosed or on a read/decode error, so both readers write into the same
length buffer and reset the same msgpack decoder with no happens-before
edge between them.

Make both of them locals of reader() and drop the now-unused Connection
fields. The added test drives the existing mockIoConn with a long prepared
response stream and a Flush() that fails after a short delay, which
reproduces the overlap deterministically enough for -race to report it.
Flush() gained the two fields it needs to fail; the rest of the mock is
already what the test wants.

Pull Request Pull Request #603: connection: fix data race between two reader goroutines

Coverage Stats

9 of 9 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

3189 of 4170 relevant lines covered (76.47%)

85315.05 hits per line