IJHack / QtPass / 34832635679

93%

push

github

Backport: keep the keygen passphrase out of the template box (#1709) (#1718)

* Keep the GPG passphrase out of the keygen template box (#1682) (#1687)

KeygenDialog::on_passphrase1_textChanged() copied the value of the masked
passphrase fields into the always-readable, selectable batch template
editor as a "Passphrase: ..." line, and rewrote it on every keystroke.
Anyone looking at (or over the shoulder of) the dialog could read the
key passphrase in clear text, defeating the QLineEdit::Password fields.

The template now stays passphrase-free while the dialog is open. A new
static KeygenDialog::applyPassphrase() splices the passphrase into the
batch only in done(), just before the text is handed to
ConfigDialog::genKey(): it replaces the %no-protection control line (or
an existing Passphrase: line an expert typed) with a Passphrase:
parameter, inserting one before %commit if the template has neither, and
turns a Passphrase: line back into %no-protection when the fields are
empty. Values are spliced as plain strings.

The template editor is hidden unless the Expert checkbox is ticked so a
non-expert is not shown a %no-protection placeholder that no longer
reflects the passphrase they typed. replace() loses its dead Passphrase
branch and no_protection() is removed.

The backlog entry also claimed the regex replacement mangled values
containing \1-\9. That does not reproduce on Qt 6: QString::replace()
only expands backreferences up to the pattern's capture count, and the
pattern has none, so the name/email replacement is left as it was.

Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
(cherry picked from commit 8f86ef2ba)

Backport to 1.8 (#1709): applyPassphrase() keeps the Qt < 5.15
QString::SkipEmptyParts split guard that main carries in replace(), and
the %commit index uses auto instead of qsizetype so it is an int on Qt 5.

* Follow-up t... (continued)

21 of 23 new or added lines in 1 file covered. (91.3%)

4909 of 7259 relevant lines covered (67.63%)

76.42 hits per line