IJHack / QtPass / 34832253743

93%

Build Type

push

github

Committed by web-flow

Commit Message

Backport: seed new-folder .gpg-id from parent recipients (#1709) (#1714)

* fix: seed new-folder .gpg-id from parent recipients (#1682) (#1688)

(cherry picked from commit a82adcde2)

* Follow-up to #1688: never seed an unsigned .gpg-id, test the seeding (#1695)

#1688 made "Add folder" copy the parent's recipients into the new
folder's .gpg-id, but it did so unconditionally. With passSigningKey
configured that file has no .gpg-id.sig, so ImitatePass::Insert
(verifyGpgIdFile) and real pass (PASSWORD_STORE_SIGNING_KEY) refuse
every insert into the folder until UsersDialog re-inits it. The write
was also inlined in a private slot behind QInputDialog, so #1682 had no
regression test.

Move the write into Pass::seedGpgIdFile(newDir, passStore): it resolves
the inherited recipients from newDir/.gpg-id (so a trailing separator
on newDir is harmless), refuses to overwrite an existing file, writes
nothing when no recipient is inherited, and keeps the QSaveFile +
owner-only permissions from #1688. MainWindow::addFolder calls it only
when no signing key is configured; with one, the folder is left without
its own .gpg-id and inherits the parent's signed list, which encrypts to
the same recipients. Add tst_util cases for the copy (comment lines and
an email recipient in the parent), the trailing separator, the
no-recipients refusal and the no-overwrite guard.

Backport to main (#1709): also drop the <QTextStream> include #1688 added
to mainwindow.cpp, which this commit leaves unused (2.0-nazomer removed
it later; it was also mis-sorted for clang-format).

Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit a8bed36bc)

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

14 of 18 new or added lines in 2 files covered. (77.78%)

1 existing line in 1 file now uncovered.

4735 of 7259 relevant lines covered (65.23%)

61.05 hits per line