stillwater-sc / universal / 34819345064

86%

master: 84%

Build Type

push

github

Committed by web-flow

Commit Message

fix(einteger): print whole limbs in showLimbs() (#1496)

showLimbs() called to_binary(number, bNibbleMarker, nbits) as
to_binary(_block[i], sizeof(BlockType) * 8, true): the limb width landed in
bNibbleMarker and true landed in nbits, so every limb printed as its least significant
bit. einteger<uint8_t>(-1234567890123).showLimbs() gave "0b1 0b1 0b1 0b1 0b0 0b1" for
limbs 1, 31, 113, 251, 4, 203, and gcc flagged both calls with -Wint-in-bool-context.
The arguments are now in order, at both call sites.

The new elastic/einteger/api/show_limbs.cpp checks showLimbs() and showLimbValues()
against the limbs of the value, formatted independently of to_binary. It covers the
reported case and 1000 random values of both signs up to 62 bits for each of uint8_t,
uint16_t and uint32_t limbs. Against the old header every showLimbs() case fails, and
showLimbValues() was already right. With the fix all 15 einteger tests pass on gcc 13.3
and clang, and the warning is gone.

Closes #1456

BEHAVIOUR-CHANGE: einteger::showLimbs() now prints each limb in full (was one bit per limb)

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NazYbxaii2XXVzQeQKMDTs

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

43704 of 50933 relevant lines covered (85.81%)

7676235.87 hits per line