stillwater-sc / universal / 34794035930
86%
master: 84%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran
Jobs 1
Files 667
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.729% (-0.03%) from 85.763%
34794035930

push

github

web-flow 
fix(headers): define each core's behaviour switches in the core (#1436) (#1493)

Seven layered cores tested a *_THROW_ARITHMETIC_EXCEPTION switch that only their
umbrella defined, so a translation unit that includes core.hpp alone, as #1334 tells
callers they may, left it undefined. -Wundef on every core found exactly those seven
plus areal:

| core | undefined in a core-only TU |
|---|---|
| edecimal | EDECIMAL_THROW_ARITHMETIC_EXCEPTION |
| erational | ERATIONAL_... and EDECIMAL_... (it layers on edecimal) |
| fixpnt | FIXPNT_THROW_ARITHMETIC_EXCEPTION |
| posit | POSIT_THROW_ARITHMETIC_EXCEPTION |
| qd | QUADDOUBLE_THROW_ARITHMETIC_EXCEPTION |
| rational | RATIONAL_THROW_ARITHMETIC_EXCEPTION |
| takum | TAKUM_THROW_ARITHMETIC_EXCEPTION |
| areal | TRACE_CONVERSION (tested at line 38, defaulted at line 58) |

Each default moves from the umbrella into the type's _impl.hpp, directly after
#pragma once, which is where most layered types keep theirs. Two blocks move with
their forwarding: posit's to BLOCKTRIPLE_THROW_ARITHMETIC_EXCEPTION and to the quire,
and fixpnt's to the quire. qd's QUADDOUBLE_EXCEPT moves too. Apart from posit's
blocktriple forwarding, below, the blocks are verbatim, so the definitions are
unchanged. The umbrellas keep a comment saying where the default lives. areal's
default moves above its first use.

posit's forwarding to BLOCKTRIPLE_THROW_ARITHMETIC_EXCEPTION is now a separate guarded
block (CodeRabbit on #1493). The umbrella defined it unconditionally in its #else, so a
caller who set both switches got a redefinition warning and had their BLOCKTRIPLE value
overridden. Now it is defined, as POSIT_THROW_ARITHMETIC_EXCEPTION, whenever the
caller has not set it, including with posit's defaults, where the umbrella left it
undefined (the same value, 0, in #if). Nothing in the tree tests that macro, so no code
changes. posit_impl.hpp's own forwarding block, which set it to 1 when the posit switch
was 1, duplicated this and is gone.

... (continued)

43631 of 50894 relevant lines covered (85.73%)

7572929.03 hits per line

Coverage Regressions

Lines Coverage ∆ File
10
31.43
 -3.21% include/sw/universal/verification/test_suite_randoms.hpp
8
93.06
 -0.52% include/sw/universal/number/cfloat/cfloat_impl.hpp
Jobs
ID Job ID Ran Files Coverage
1 34794035930.1 667
85.73
 GitHub Action Run
Source Files on build 34794035930