microlinkhq / browserless / 34779667703

79%

Build Type

push

github

Committed by web-flow

Commit Message

fix(goto): deny notifications by default (#931)

--disable-notifications kept sites from asking, but it removed Notification
and PushManager from every page, which is why #922 dropped it, and it left
navigator.permissions.query answering prompt for an API that was not there.
Sites went back to rendering their own opt-in overlays.

Chrome reports denied from both Notification.permission and
permissions.query for a user who blocked notifications, with every standard
Web API still exposed. CDP Browser.setPermission reproduces that pair
exactly, scoped to the page's browser context, and touches no other
permission the way Browser.grantPermissions behind
BrowserContext.overridePermissions would.

notifications: true restores Chrome's out-of-the-box prompt state.


Claude-Session: https://claude.ai/code/session_0116zka7w2WKPSi3kqHyVAET

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Coverage Stats

1158 of 1371 branches covered (84.46%)

Branch coverage included in aggregate %.

28 of 28 new or added lines in 2 files covered. (100.0%)

260 existing lines in 1 file now uncovered.

5239 of 6701 relevant lines covered (78.18%)

75160.72 hits per line