ruby-grape / grape / 34777197939

99%

master: 99%

Pull #2942

github

Route raw non-ASCII paths when an API declares a non-ASCII route

Rack hands PATH_INFO over binary, and matching a binary string that holds
non-ASCII bytes against a UTF-8 regexp raises Encoding::CompatibilityError.
A route whose path holds a non-ASCII literal (`/café/:id`) compiles to such
a regexp, and every request is matched against a union that holds it. So
once an API declared one, every request whose path carried raw non-ASCII
bytes raised, whichever route it was meant for and whether or not the bytes
were valid UTF-8. The percent-encoded spelling of the same path routed.

Router#compile! now records whether any compiled union has a fixed encoding.
Only then, and only for a path that is not ASCII, the router routes a copy
of the path tagged UTF-8 and publishes that copy as the normalized path. A
path whose bytes are not UTF-8 cannot be matched against those routes at
all, so it is answered as a path no route matched. PATH_INFO itself stays
binary, and an API without a non-ASCII route routes exactly as before.
Router#recognize_path gets the same treatment.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1380 of 1429 branches covered (96.57%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 1 file covered. (100.0%)

4156 of 4156 relevant lines covered (100.0%)

27053.38 hits per line