stillwater-sc / universal / 34764208093

86%

master: 84%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(headers): split sorn into core / manipulators / iostream (#1334) (#1471)

* refactor(headers): split sorn into core / manipulators / iostream (#1334)

Fourth type of Phase 2 group 5c (#1467).

    core.hpp   50,664 lines / 251 headers / 0 I/O-family
    sorn.hpp   68,271 lines / 332 headers / 4 I/O-family  (was 68,241 / 329 / 4)

Zero I/O-family headers is met. Under-45,000 lines is not: the standard headers
sorn itself uses -- <bitset>, <vector>, <cmath>, <string>, <limits> -- are
48,241 lines on their own, so the floor is the standard library, not a
Universal substrate. The core is that plus ~2,400 lines.

(Scope is `headers` because `sorn` is not in the PR-title allow-list.)

The text lived in members

- sornInterval::getInt(), sorn::getConfig() and sorn::getDT() build text with a
  stringstream. Each is declared in its class and defined out-of-line in
  manipulators.hpp.

TWO stream operators, and which one a call picks is sorn's behaviour

sorn has two operator<< overloads that print different things: a NON-const
sorn prints its current interval ("(1,1.5]"), a const sorn -- or a temporary --
prints the range of its lattice ("[ -inf, inf]"). The non-const one was a
hidden friend DEFINED in the class; the const one a namespace-scope template.
Both move to iostream.hpp as function templates. That keeps the choice: with
both overloads templates, a non-const lvalue still binds the sorn& overload,
because it needs fewer added cv-qualifications ([over.ics.rank]); a const
lvalue or an rvalue can only bind the const one. The differential checks it
directly: every value is streamed both ways, and so are the temporaries (-v,
abs()) and the named arithmetic results.

iostream.hpp includes manipulators.hpp: the non-const operator prints through
getInt(). manipulators.hpp does not include it back.

Self-containment, each found by compiling the header alone:

- numeric_limits.hpp used INFINITY and named sorn with no includes: now <cmath>,
  <limits> an... (continued)

Coverage Stats

29 of 31 new or added lines in 2 files covered. (93.55%)

49 existing lines in 5 files now uncovered.

43285 of 50504 relevant lines covered (85.71%)

7163348.57 hits per line