stillwater-sc / universal / 34734747263

86%

master: 84%

push

github

refactor(areal): split areal into core / manipulators / iostream / debug (#1334) (#1452)

Last type of Phase 2 group 5a (#1444). areal had the group's largest std::cout
population -- 51 sites -- and almost all of them were already correctly guarded.

    core.hpp        73,412 lines / 345 headers / 0 I/O-family
    areal.hpp       82,620 lines / 372 headers / 5 I/O-family  (was 83,655 / 386 / 5)

Zero I/O-family headers is met. Under-45,000 lines is not, and reporting the
number rather than moving the bar: internal/blocktriple/blocktriple.hpp is 69,758
lines on its own (already 0 I/O), so this core is blocktriple plus about 3,650.
Same ceiling dbns hit (#1449); it belongs to the substrate.

The 51 cout sites were not the problem. The include was.

49 of them already sat behind areal's TRACE_CONVERSION switch, which was already
externally settable -- the defect #1387 found elsewhere was not present here.
What kept four I/O-family headers in every areal translation unit was that the
`#include <iostream>` sat OUTSIDE the guard. It now sits inside it, with the code
that needs it. Same move cfloat's trace includes got in #1417/#1418.

The remaining two:

- constexprClassParameters(), a member function with 19 cout statements, is
  declared in the class and defined out-of-line in debug.hpp -- the shape
  blocktriple's got in #1388.
- assign()'s "assign TBD" stub prints with std::printf instead of std::cout: same
  destination, same text, no stream header. stdout ordering with std::cout is
  guaranteed while sync_with_stdio is on, which is the default.

Two structural finds this surfaced, both of which cost the core its zero

1. numeric_limits.hpp included the areal.hpp UMBRELLA. Since the umbrella
   includes the core, that is a cycle -- core -> numeric_limits -> umbrella ->
   manipulators + iostream -- that #pragma once merely masked, and it left
   core.hpp measuring 82,614 lines with all five I/O-family headers, seven lines
   short of the umbrella itse... (continued)

40 of 40 new or added lines in 3 files covered. (100.0%)

43185 of 50422 relevant lines covered (85.65%)

7174754.66 hits per line