solidjs / solid / 34728818399

72%

main: 89%

push

github

fix(signals): OBSERVE.exclude covers store nodes and interaction writes (#3380)

* fix(signals): OBSERVE.exclude covers store nodes and interaction writes

A root write to an excluded subject no longer counts toward the interaction
that made it, and an interaction whose writes all went to excluded subjects
with none of the app's work run — a click on a devtools panel's own button —
is dropped from the ring and never delivered.

Store nodes were never excluded subjects: registerGraph's `_owner` stamp on
the proxy is swallowed by the set trap outside a draft. The root target now
keys its creating owner and nodes copy it into `_owner` as they are created,
under the same engine-installed gate as node naming.

Found by the Sentry spike's record-driven adapter. Engine scenario
26888 -> 26944 B; observe CSR tier unchanged.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* perf(signals): record a store's owner only once the observe engine is installed

A WeakMap.set per fresh store regressed the 2000-store create+commit
shape (~+30% locally, CodSpeed -11.7%). Gate it on attrHooks like the
node stamping it feeds; disabled it bought nothing. Size note rebased.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.02 hits per line