solidjs / solid / 34726273332

72%

main: 89%

push

github

fix(web): run hydration events after dynamic() spreads a string tag (#3386) (#3396)

* docs: correct createContext guidance for server rendering

The createContext JSDoc told readers to reach for a module-scope
signal or store for app-wide state. With ssr: true a module is
evaluated once per process, so that state is shared by every request:
a store derived from a server function leaks one user's data into
another's render, and a module-scope signal has no owner to dispose
it. The 2.0 docs say the opposite, and the reference page is generated
from this JSDoc, so the site contradicted itself.

Also fix two smaller items in the same examples:

- The createContext and useContext @example blocks render <TodoList />,
  whose stub returns nothing, so the examples fail tsc as written.
- The handleServerFunctionRequest @example imported from
  "@solidjs/web/server-functions", which resolves to the client entry
  under the browser condition; the function is exported from
  "@solidjs/web/server-functions/server".

* fix: run hydration events after dynamic() spreads a string tag

Compiled JSX calls runHydrationEvents() after an element that carries
event handlers, so events the hydration script queued for it are
replayed once it hydrates. The string-tag branch of dynamic() binds
handlers through spread() and never made that call, so a page whose
interactive elements are all <Dynamic> dropped queued events until
_$HY.done, unless some other compiled element happened to hydrate
afterwards and made the call for it.

Call runHydrationEvents() after spread() when hydrating. The hydrating
flag is read before spread() so the branch cannot observe a different
value than the one that chose getNextElement().

* chore: add changeset for dynamic() hydration events fix

* test: cover hydration event replay for dynamic() string tags

Queues a click for the server-rendered button of a <Dynamic component=
"button"> before hydrating, and asserts the handler runs. The spec fails
... (continued)

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.01 hits per line