solidjs / solid / 34725672948

71%

main: 89%

push

github

fix(signals): second write while an async chain is in flight (#3373, #3374, #3375, #3376) (#3381)

* fix(signals): second write while an async chain is in flight (#3373, #3374, #3375, #3376)

A flight's landing retires only the node's own pending entry (`landStatus`).
An input re-asked mid-flight (`a` restarted while `b`'s first flight was up)
marks `b` pending on `a` by propagation with `b`'s flight still current —
nothing superseded it — and the full `clearStatus` at landing wiped that
entry: the stale answer read as settled, the transaction's reporter for `a`
found nothing pending below it, and the newer signal committed beside the
older derived value (`2 / 1`, #3373); `isPending(b)` blipped false (#3376).
The landed value is still written and held; `a`'s settle releases it or its
value change re-asks `b`. Complement at registration: a fresh flight drops
entries its inputs propagated earlier — the run read them, so a pending input
was masked for it (an active override, A17) and does not describe the answer.

`transitionComplete` tests a source's own flight by its self entry in
`_pendingSources`, not `_error.source`, which a later-pending input overwrites
on propagation while the flight is still in the air — the held write no longer
commits ahead of its answer once the load is re-asked under an `on`-scoped
boundary (#3375).

A collecting `Loading` boundary records every source the notifying effect is
pending on, not only the one the notification carries. Status propagation
dedupes on the effect's `_pendingSources`, so a source carried across an `on`
reset was never re-reported and its re-flight stayed invisible — the boundary
revealed when its one collected source settled with the effect still pending
(#3375).

A stale reader served a pending node's committed value by the reveal
carve-out (`heldFromStale`) joins the transaction's reporters for that node
when it has an entry: it displays the pre-flight value, so a keyed remount
that disposes the read... (continued)

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.01 hits per line