corbym / gocrest / 34723491606

3%

Build Type

push

github

Committed by corbym

Commit Message

fix: correctness bugs, data races, and test isolation

- listContains/listMatches: replace value-deduplicating maps with multiset
  count map and greedy used-slot tracking so duplicate expected elements
  work correctly
- mapActualContainsExpected: simplify to per-key equality check, fixing
  false negatives when multiple keys share the same value
- mapActualContainsExpectedValues/mapActualMatchesExpected: same multiset
  and greedy fixes; remove stale A map[K]V generic constraint
- Eventually: store Merge result atomically under its own lock; replace
  defer close(channel) with a done channel so goroutines exit cleanly
  instead of panicking on send-to-closed-channel (race detected by -race)
- StructWithValues: replace both panics (missing field, non-struct actual)
  with graceful match.Actual + return false
- AllOf: reset Actual per call; only overwrite Describe on failure so
  successful calls restore the original description (fixes stale Describe
  after Eventually re-runs)
- AnyOf/EveryElement/StructWithValues: reset Actual at start of each
  Matches call; move AppendActual inside closure so sub-matcher Actual
  values are read after Matches has run
- matcher_test.go: reset stubTestingT before each assertion in tests that
  relied on global state without a fresh allocation
- CI: add go vet ./... step between Build and Test

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WgMsSEv994dqaMbH3ojFYk

Coverage Stats

0 of 73 new or added lines in 6 files covered. (0.0%)

5 existing lines in 3 files now uncovered.

25 of 767 relevant lines covered (3.26%)

0.12 hits per line