d-led / gen_server_virtual_time / a3917c9139db99c265355a499efb1039d306eda2

88%

push

github

style: clear the length/1 warnings, Credo is clean

Credo's expensive-empty-enum check flagged 42 places comparing the result of
length/1 against zero. Replaced with the direct comparison it asks for:
length(x) > 0 becomes x != [] and length(x) >= 1 becomes x != [].

Every expression was checked to hold a list before rewriting. Two do not always:
in mermaid_report_generator one is an option that may be nil and another is
wrapped in || [], so a plain != [] would have changed the outcome (nil != []
is true, where the original short-circuited to falsy) - those use
not in [nil, []] instead, which preserves the behaviour exactly.

mix credo --strict now reports no issues, down from 42 warnings, so the quality
job in CI has nothing to tolerate.

25 of 27 new or added lines in 6 files covered. (92.59%)

2067 of 2395 relevant lines covered (86.3%)

10543.45 hits per line