microlinkhq / browserless / 34698893803

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(goto): emulate a screen consistent with the device viewport (#923)

* fix(goto): emulate screen and client hints consistent with the device

Desktop viewports rendered inside the 800x600 headless screen, so device-width media queries matched tablet layouts. Chrome user agents were overridden without UA-CH metadata, which removed sec-ch-ua headers and emptied navigator.userAgentData.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0116zka7w2WKPSi3kqHyVAET

* fix(goto): fit the headless screen per browser and restore device metrics

Emulation.updateScreen resizes the headless screen for the whole browser, so Puppeteer's own metrics overrides keep a screen that fits the viewport. That removes the stacked setDeviceMetricsOverride and survives page.setViewport re-applies. goto now compares against page.viewport(), so switching from a mobile device back to a desktop one restores desktop metrics, and repeat navigations skip setViewport. Android WebView user agents report the Android WebView brand.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0116zka7w2WKPSi3kqHyVAET

* fix(goto): recover the browser screen state after a failed fit

A rejected screen fit poisoned the per-browser promise chain, so every later navigation on that browser skipped fitting the screen.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0116zka7w2WKPSi3kqHyVAET

* test(goto): cover screen update failures and run the screen path in mocks

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0116zka7w2WKPSi3kqHyVAET

* fix(goto): emulate the screen per page instead of per browser

The browser-wide Emulation.updateScreen state leaked between pages and clients: a goto could shrink the screen under another connect-mode client, ... (continued)

Coverage Stats

1046 of 1250 branches covered (83.68%)

Branch coverage included in aggregate %.

121 of 121 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

4764 of 5944 relevant lines covered (80.15%)

84701.67 hits per line