moonbitlang / core / 6638

89%

push

github

refactor(hashset): reuse difference in symmetric_difference

HashSet::symmetric_difference repeated the entire body of
HashSet::difference -- new_hashset(default_init_capacity) followed by
self.each(k => if !other.contains(k) { m.add(k) }) -- before adding its
mirrored second phase, so the "keys of self that other lacks" policy had
two owners 11 lines apart under the same documented semantics.

Delegate that first phase to self.difference(other) instead. The removed
lines are byte-identical to the delegated statements, so the result keeps
the same membership (self union other minus self intersect other), the
same accumulator, length() and capacity(), the same Robin Hood slot and
iteration order, and the same Hash/Eq call order; neither operand is
mutated and no public signature or .mbti entry changes.

Co-Authored-By: SeekMoon <seekmoon@moonbitlang.com>

1 of 1 new or added line in 1 file covered. (100.0%)

16443 of 18407 relevant lines covered (89.33%)

272786.63 hits per line