ruby-grape / grape / 34685089796

99%

master: 99%

Pull #2937

github

Forward the class methods kept off an API class to its base instance explicitly

`.override_all_methods!` redefines every base-instance method on the API
class itself, so that calling one records a setup step to replay on each
mounted instance. `NON_OVERRIDABLE` keeps a few names off that list, and
only seven of them had a `def_delegators` entry; `base=`,
`base_instance?`, `reset!` and `top_level_setting` were answered by
`delegate_missing_to :base_instance` through `method_missing`. They are
forwarded explicitly now, so the class states the surface it answers.

`delegate_missing_to` stays for the names no list can hold: anything
defined on `Grape::API::Instance` after an API class was created, since
`.override_all_methods!` copies the methods it finds at that moment.
That is how a gem adds to the DSL, and two specs now pin both halves --
nothing did, and deleting the delegation left the suite green.

`inherit_settings` keeps its place in NON_OVERRIDABLE, with a comment
saying why: it is protected on the base instance, and `.methods` answers
protected methods too, so without it `.override_all_methods!` would give
the class a recording method for it. It gets no delegator, since a public
one would raise NoMethodError exactly as the missing method does.

`top_level_setting=` leaves the list: no such method exists, so the entry
excluded nothing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1306 of 1350 branches covered (96.74%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

4039 of 4039 relevant lines covered (100.0%)

27252.27 hits per line