GavinHuttley / scinexus / 34674220488

100%

push

github

BUG: a part built closing reader closes without raising

io.IOBase calls close from __del__, and _ClosingReader.close reached
for self._reader and self._stream and let the AttributeError out when
neither was there. An instance without them is not hypothetical: it is
what copy.copy builds before it looks for __setstate__, and it is what
__new__ gives. An exception in __del__ cannot be raised, so it was
reported as an unraisable, which the Windows runner surfaced as a
PytestUnraisableExceptionWarning against a test that only meant to
check the attribute guard.

close now looks the two up in __dict__ and closes what is there. The
lookup stays out of the annotations so that read, seek and tell keep
taking a reader rather than an optional one, since they are not
reachable on an instance in that state.

6 of 6 new or added lines in 1 file covered. (100.0%)

2619 of 2624 relevant lines covered (99.81%)

5.9 hits per line