ConnectionMaster / json / 34666500751

98%

Build Type

push

github

Committed by web-flow

Commit Message

Fix two develop CI regressions: dump() nodiscard warning and binary-reader const-correctness (#5520)

* Discard dump()'s [[nodiscard]] return value in an exception-only check

CHECK_THROWS_WITH_AS(j.dump(), ...) called dump() only to trigger and
catch the exception, but never used the return value. dump() is
warn_unused_result, so GCC's pedantic build (-Werror --all-warnings)
rejected it as -Werror=unused-result, breaking ci_test_gcc. Wrapped in
utils::ignore_return_value(), matching every other such call in this
file.

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

* Mark container_frame top as const in CBOR/UBJSON readers

clang-tidy's misc-const-correctness flagged these on PR #5520's CI: the
BSON sibling copy was already const, but these two were left mutable
even though only container_stack.back().remaining is ever written.

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

---------

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

Coverage Stats

2579 of 2797 branches covered (92.21%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

126 existing lines in 5 files now uncovered.

7328 of 7490 relevant lines covered (97.84%)

15636594.17 hits per line