ConnectionMaster / json / 34523863486

98%

Build Type

push

github

Committed by web-flow

Commit Message

Fix to_bjdata() silently truncating out-of-range _ArrayData_ elements (#5473)

write_bjdata_ndarray() validated that each _ArrayData_ element matched
the number kind (integer vs. float) named by _ArrayType_, but not its
range. An element that did not fit the target C++ type (e.g. 256 for
"uint8") was silently wrapped by the static_cast used to write it, or,
for "single", silently overflowed to infinity.

Range-check each element against the type named by _ArrayType_ before
writing it, reusing the existing fallback path that already encodes
the annotated object as a plain object for other invalid-annotation
cases in this function.

Fixes #5403.

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

Coverage Stats

2491 of 2681 branches covered (92.91%)

Branch coverage included in aggregate %.

41 of 41 new or added lines in 1 file covered. (100.0%)

17 existing lines in 3 files now uncovered.

7054 of 7160 relevant lines covered (98.52%)

15671067.67 hits per line