microlinkhq / browserless / 34595180841

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(goto): run Ghostery DOM scans in an isolated world (#927)

* fix(goto): run Ghostery DOM scans in an isolated world

Ghostery's Puppeteer adapter calls frame.evaluate for its cosmetic
feature extraction and blocked-iframe scan, which runs in the page main
world where page hooks see the automation stack. Route those evaluations
through the frame's isolated realm; scriptlets and style injection keep
their existing behavior.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0116zka7w2WKPSi3kqHyVAET

* test(goto): keep Ghostery tests local and pin the whole DOM scan

The blocked iframe pointed at securepubads.g.doubleclick.net, and the
adapter lets document requests through before removing the frame, so the
test sent real traffic from CI. Serve it from framed-ad.localhost and
block it with test-only rules added to the engine, so neither the network
nor the prebuilt lists affect the result.

The leak test now also hooks getAttribute, classList, nodeName and
documentElement and flags every call from extractFeaturesFromDOM, not
just the querySelectorAll selectors.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0116zka7w2WKPSi3kqHyVAET

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Coverage Stats

983 of 1185 branches covered (82.95%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 1 file covered. (100.0%)

13 existing lines in 3 files now uncovered.

4640 of 5826 relevant lines covered (79.64%)

86402.04 hits per line