akvo / eswatini-droughtmap-hub / #221

89%

push

coveralls-python

fix: Remove duplicate soft delete methods from SystemUser model

The delete/soft_delete/restore methods were copy-pasted from SoftDeletes mixin, which broke hard deletes due to MRO. When calling super().delete() with hard=True, the method resolution order (SystemUser -> AbstractBaseUser -> PermissionsMixin -> SoftDeletes) caused it to land back on SoftDeletes.delete() with hard defaulting to False, resulting in silent soft-deletion. Fixed by removing the duplicate methods and relying on proper inheritance.

1929 of 2448 branches covered (78.8%)

Branch coverage included in aggregate %.

8923 of 9746 relevant lines covered (91.56%)

0.92 hits per line