|
Ran
|
Jobs
1
|
Files
777
|
Run time
2min
|
Badge
README BADGES
|
push
github
chore: small improvements (#8001) Description --- adds two small improvements to not get false alarms about security * test for duplicate commentments * not use unwrap in rangeproof verification <!-- greptile_comment --> <!-- greptile_summary --> <h2><a href="https://app.greptile.com/api/retrigger?id=62626134"><picture><source media="(prefers-color-scheme: dark)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=1"><source media="(prefers-color-scheme: light)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=1"><img alt="Retrigger" src="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=1" align="right"></picture></a>Confidence Score: 5/5</h2> The PR appears safe to merge, with no concrete correctness or security regressions identified. <h3>Summary</h3> - Maps metadata challenge scalar-conversion failures to `InvalidRangeProof`. - Tests hash-based duplicate detection in the chain validator. - Tests commitment/output-hash uniqueness in internal and full block validation. <sub>Reviews (1) · Last reviewed commit: ["test(validation): cover duplicate commit..."](https://github.com/tari-project/tari/commit/21e05d235)</sub> <!-- /greptile_comment --> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
189 of 192 new or added lines in 4 files covered. (98.44%)
23 existing lines in 6 files now uncovered.85769 of 136856 relevant lines covered (62.67%)
194186.22 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 3 |
93.36
|
-0.51% | base_layer/transaction_components/src/transaction_components/transaction_output.rs |
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 7 |
73.03
|
-1.97% | comms/core/src/protocol/messaging/protocol.rs |
| 5 |
56.4
|
-0.63% | base_layer/core/src/base_node/comms_interface/inbound_handlers.rs |
| 4 |
67.98
|
-1.97% | comms/core/src/connectivity/requester.rs |
| 4 |
89.57
|
-2.45% | comms/core/src/protocol/messaging/outbound.rs |
| 2 |
83.81
|
-0.32% | comms/core/src/protocol/rpc/client/mod.rs |
| 1 |
38.6
|
-0.04% | base_layer/wallet/src/transaction_service/storage/sqlite_db.rs |
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 34511495223.1 | 777 |
62.67
|
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|