tari-project / tari / 34484789822
76%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 777
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 62.609% (+0.4%) from 62.255%
34484789822

push

github

web-flow 
fix: sender offset and script key should not leave key manager (#8000)

Description
---
Changes the way the script offset is calculated to enforce security of
the script key and sender offset key

<!-- greptile_comment -->

<!-- greptile_summary -->

<h2><a
href="https://app.greptile.com/api/retrigger?id=62559716"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=1"><source
media="(prefers-color-scheme: light)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=1"><img
alt="Retrigger"
src="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=1"
align="right"></picture></a>Confidence Score: 4/5</h2>

The PR appears safe to merge, with a non-blocking API-hardening issue
around transaction-shaping mutations after sender-offset reservation.

<h2><a
href="https://app.greptile.com/ide/claude-code?prompt=%23%23%23%20Issue%201%0Abase_layer%2Ftransaction_components%2Fsrc%2Ftransaction_builder%2Fbuilder.rs%3A422-424%0A%60with_host_derived_partial_script_offset%60%20remains%20callable%20after%20%60reserve_sender_offset_keys%60%2C%20even%20though%20reservation%20makes%20the%20script%20offset%2C%20fee%2C%20and%20change%20decision%20binding.%20Enforce%20the%20collecting%20phase%20for%20this%20and%20other%20transaction-shaping%20mutators%20so%20callers%20cannot%20create%20state%20inconsistent%20with%20the%20reserved%20keys%20and%20transaction%20shape.%0A%0ANote%3A%20If%20this%20suggestion%20doesn't%20match%20your%20team's%20coding%20style%2C%20reply%20to%20this%20and%20let%20me%20know.%20I'll%20remember%20it%20for%20next%20time!%0A%0A---%0A%0AFor%20each%20issue%20above%2C%20determine%20whether%20it%20is%20valid%20and%20should%20be%20fixed.%20If%20so%2C%20fix%20it%20directly.&repo=tari-project%2Ftari&pr=8000&platform=github"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/bad... (continued)

1599 of 1993 new or added lines in 23 files covered. (80.23%)

93 existing lines in 18 files now uncovered.

85565 of 136665 relevant lines covered (62.61%)

194445.09 hits per line

Uncovered Changes

Lines Coverage ∆ File
115
0.0
0.0% base_layer/wallet/src/transaction_service/service.rs
86
91.27
-0.8% base_layer/transaction_components/src/transaction_builder/builder.rs
51
34.62
-65.38% base_layer/transaction_components/src/transaction_builder/models.rs
50
2.34
0.11% base_layer/wallet/src/output_manager_service/service.rs
24
0.0
0.0% applications/minotari_ledger_wallet/comms/src/accessor_methods.rs
20
0.0
0.0% applications/minotari_ledger_wallet/comms/src/ledger_wallet.rs
19
87.71
-0.6% base_layer/transaction_components/src/offline_signing/one_sided_signer.rs
15
65.65
6.79% base_layer/transaction_components/src/key_manager/manager.rs
8
58.1
9.97% base_layer/transaction_components/src/multisig/session.rs
5
21.84
21.84% base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs
1
0.0
0.0% base_layer/transaction_components/src/offline_signing/marshal_output_pair.rs

Coverage Regressions

Lines Coverage ∆ File
32
45.68
-4.86% base_layer/transaction_components/src/transaction_components/wallet_output.rs
19
91.27
-0.8% base_layer/transaction_components/src/transaction_builder/builder.rs
12
72.93
-3.42% base_layer/transaction_components/src/transaction_components/wallet_output_builder.rs
5
55.15
-0.13% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
5
2.34
0.11% base_layer/wallet/src/output_manager_service/service.rs
5
0.0
0.0% base_layer/wallet/src/transaction_service/service.rs
3
80.92
-0.99% comms/core/src/connection_manager/manager.rs
2
84.13
-0.32% comms/core/src/protocol/rpc/client/mod.rs
1
0.0
0.0% applications/minotari_ledger_wallet/comms/src/accessor_methods.rs
1
25.29
-1.15% base_layer/core/src/chain_storage/error.rs
1
79.45
-1.37% base_layer/node_components/src/blocks/chain_block.rs
1
90.0
-0.18% base_layer/p2p/src/services/liveness/service.rs
1
65.65
6.79% base_layer/transaction_components/src/key_manager/manager.rs
1
58.1
9.97% base_layer/transaction_components/src/multisig/session.rs
1
84.0
-0.2% comms/core/src/connection_manager/dialer.rs
1
69.95
-0.49% comms/core/src/connectivity/requester.rs
1
82.14
-0.2% comms/core/src/noise/socket.rs
1
83.33
-0.93% comms/core/src/protocol/messaging/inbound.rs
Jobs
ID Job ID Ran Files Coverage
1 34484789822.1 777
62.61
GitHub Action Run
Source Files on build 34484789822