hyperledger / fabric-x-common / 34488940055

82%

main: 82%

Pull #186

github

[testcrypto] Let a block's owner prepare it without a clone or a rehash

#### Type of change

- New feature
- Test update

#### Description

- `InPlace` writes the header and metadata into the block passed in, rather than into a deep clone of
  it. The clone is what makes it safe to prepare a block the caller intends to reuse or submit twice,
  so this is opt-in: for a producer that built the block for this call alone, the copy is pure waste.
- `ReuseDataHash` takes the data hash from the header the caller already filled in, so a producer can
  compute it off this call's critical path. It is ignored when the block has no header or an empty
  hash, so a caller that sets it and forgets to supply one gets a correct block rather than a silently
  corrupt one.
- Both default to today's behaviour, so no existing caller changes.
- Tested by equivalence, which is the only thing that makes the options worth having: the block
  prepared the fast way is proto-identical to the block prepared the cloning way, in place returns the
  same object it was given, and asking to reuse a hash that was never supplied still produces the
  right one.

#### Related issues

- resolves #185

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

8 of 8 new or added lines in 1 file covered. (100.0%)

13644 of 16647 relevant lines covered (81.96%)

0.82 hits per line