solidjs / solid / 34460296793

72%

main: 89%

push

github

fix(signals,solid,web): dev-gate the #3338 diagnostics; size gate back to green

fe3ab925 pushed the hydrating scenarios 240-246 B over their limits and
CSR 9 B over: the lazy() "not preloaded" explanation (~500 chars) and the
document-root preload-failure framing shipped as prod strings.

- lazyHydrationLookup: the throw is unchanged; the "check the server log
  for …" diagnosis is IS_DEV-only. Prod: `… was not preloaded before
  hydration.`
- hydrate() document root: prod hands the preload failure itself to
  `reportError` (console.error where absent) — the actionable error for
  monitoring — with no wrapper Error; the "shell cannot be client-rendered,
  hydration abandoned" framing is a dev-only console.error.
- haltReactivity: same semantics (cause to reportError when present, not
  double-logged), compacted.

Measured against the pre-#3338 baseline: +50 B hydrating, +60 B observe +
attribution, 0 elsewhere. What remains is the haltReactivity reportError
hand-off (+20 B prod core, +60 B on the observe tier's layout) plus the
document-root branch (~20 B, hydrating only). Both are the fix, not
decoration: the manifest-miss lazy() throw is a creation-time throw that
ancestors fold to status, so the halt is the only place telemetry can hear
about it. Limits bumped with reasons: hydrating 17.68 -> 17.72 KB,
observe+attribution 25.20 -> 25.26 KB.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

771 of 1006 relevant lines covered (76.64%)

15.0 hits per line