worktile / slate-angular / 16e9a457-9f0b-4a05-9342-c56cd627f2ba

36%

push

circleci

fix(core): do not sync selection while a text input outside the editor is focused (#344)

In Firefox the DOM selection stays in the editor after a text input outside the
editor gets focus (Chrome moves it out). When the editor re-renders, e.g. an
external search box changes `decorate`, `toNativeSelection` found the DOM
selection out of sync and called `setBaseAndExtent`, and since Firefox 55 setting
a selection inside an editing host moves focus to it, so it stole focus from the
input: typing "the" in the search-highlighting demo left "t" in the input and
"he" in the editor.

The re-render also replaces the text node holding the stale DOM selection, and
the following `selectionchange` synced it back to the editor selection.

- skip `toNativeSelection` when a text input outside the editor is focused
- skip syncing the DOM selection to the editor in `toSlateSelection` in that
  case, after the existing "not in editor -> deselect" check so Chrome is unchanged

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

423 of 1392 branches covered (30.39%)

Branch coverage included in aggregate %.

12 of 15 new or added lines in 2 files covered. (80.0%)

1146 of 3005 relevant lines covered (38.14%)

23.06 hits per line