worktile / slate-angular

36%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• #144
• #249
• #WIK-18594
• #WIK-19488
• #WIK-19580
• #WIK-19625
• #WIK-19814
• #WIK-19876
• #WIK-19902
• #WIK-19914
• #WIK-3849
• #WIK-3957
• #WIK-6751
• #customInsertFragmentData
• 0.53.3-copy
• 1.1.0
• 1.1.1
• 1.1.5
• 1.3.0-rc
• 1.3.1
• 1.4.0
• 1.5.1
• 1.6.1
• 1.6.5
• 1.7.0
• 1.7.4
• 1.7.5
• 1.9.0
• 13.0.2
• 13.0.x
• 13.1.x
• 14.0.x
• 16.1.0
• 16.1.0-next
• README
• WIK-563
• add-placeholder
• android-compat
• android-input
• android-input-handing
• android_input
• angular12
• angular15-upgrade
• block-card
• block-card-#269
• build/release-22.0.0
• bump-is-hotkey-direction-add-dependencies
• bump-slate
• bump-slate-0.110.0
• bump-slate-into-103
• bump-slate-v0.72.8
• bump-slate@0.114.0
• bump-slate@0.72.3
• changelog
• changesets
• children-diff
• circle-dep
• clipboard
• clipboard-files
• cmm/#v17
• compat-invalid-data
• compatible-qq
• default-string
• demo
• do-not-remove-selected-elements-in-virtual-scroll
• fake-placeholder
• feat-remove-suffix-component
• feat-standalone-component
• firefox-placeholder
• firefox-placholder-2
• fix-composing
• fix-dependencies
• fix-partial
• fix-types
• fix-void-inline-delete
• fix/firefox-external-input-focus-steal
• focus
• gboard
• generics-types
• global-normalize
• h/#WIK-563
• huan/#WIK-563
• huge-table
• is-composing
• is-composing2
• list_render
• main
• main-1
• main-2
• maple13/#WIK-4221
• maple13/#WIK-4252
• maple13/#WIK-4252-1
• maple13/#WIK-4252-2
• maple13/#WIK-4252-3
• maple13/fix-build
• maple13/fix-placeholder-decorate
• maple13/fix-selection-null
• maple13/fix-set-fragment-data
• maple13/setFragmentData
• master
• mention-demo
• mentions
• move-apply-test
• move-block-card-nodes
• move-node
• move-nodes
• nav-menu
• optimize-measure-height-timing
• optimize-typing
• performance
• placeholder-decorate
• pre-rendering
• pre-rendering-2
• precise-height
• prettier-format
• pub-1.0.0
• pub-1.0.1
• pub-1.1.3
• pub-1.1.4
• pub-1.1.6
• pub-1.1.7
• pub-1.1.8
• pub-1.2.0
• pub-1.5.2
• pub-1.6.3
• pub-1.7.0
• qq
• readme-2
• readonly
• rebase-16.1.0
• rebase-17.0.0
• rebase-two-commits
• refactor-compatible-firefox
• refactor-mark-text
• refactor-placeholder
• refactor-placeholder-2
• release-1.7.3
• release-16.1.0-next
• release-17.1.2
• remove-delete-fragment
• remove-template-element
• remove-throttle
• renderer-base-dom
• rich-text-flavour
• scroll-into-view
• scroll-into-view-if-needed
• scroll-to-upward
• search-highlighting
• selection-handle
• selectionchange
• slate-100
• spellcheck
• spellcheck-blinking
• support-flavour
• support-is-floating
• sync-slate-react@0.72.4
• table-block-card
• table-error
• test-mentions
• triple-click
• triple-click-2
• types
• update-heights-on-change
• v0.53.5-copy
• v1.3.0
• v1.3.1
• v1.3.2
• v1.8.5
• v17.0.0-next
• v18.0.0-next
• v18.x
• v19.0.0-next
• v19.2.0-next
• v20.x
• v21.0.0-next
• v21.x
• version
• view-loop-manager
• virtual-scroll
• w/#WIK-15018
• w/#WIK-15713
• w/#WIK-4475
• w/#WIK-4877
• w/#WIK-5809
• w/#WIK-5900
• w/#WIK-6050
• w/#WIK-6162
• w/1.1.9
• w/1.6.2
• w/1.9.1
• w/1.9.2
• w/1.9.3
• w/pub
• wang/#WIK-4119
• wang/#WIK-4162
• wang/#WIK-4399
• wang/#WIK-4475
• wang/#WIK-4504
• wang/#WIK-4542
• wang/#WIK-563
• wang/#WIK-6050
• wang/#WIK-697
• wang/bump
• wang/demo
• wang/pub
• wanghuan/#WIK-6050
• why520crazy/#OSP-292
• wumeimin/control-flow
• wumeimin/control-flow2
• wumeimin/ng-19.2.x
• wumeimin/update-control-flow
• wy/#TINFR-2711
• wy/#TINFR-363
• xl/#TINFR-3769
• xl/update21
• xws/#WIK-19132
• xws/#WIK-19187
• xws/#WIK-19235
• xws/#WIK-19495
• xws/#WIK-19501
• xws/#WIK-19505
• xws/#WIK-19556
• xws/#WIK-19590
• xws/#WIK-19623
• xws/#WIK-19695
• xws/#WIK-19723
• xws/#WIK-20030
• xws/#add-element-key
• xws/#block-minheight
• xws/#fix-scorll-stuck
• xws/#optimize-debug
• xws/#virtual-scroll1
• xws/#withd-change-remeasure
• xws/fix-get-measure-height-number
• xws/optimize-virtual-logs
• xws/optimize-virtual-logs2
• z
• zh-cn

Build # 16e9a457-9f0b-4a05-9342-c56cd627f2ba

Build Type

push

circleci

Committed by web-flow

Commit Message

fix(core): do not sync selection while a text input outside the editor is focused (#344)

In Firefox the DOM selection stays in the editor after a text input outside the
editor gets focus (Chrome moves it out). When the editor re-renders, e.g. an
external search box changes `decorate`, `toNativeSelection` found the DOM
selection out of sync and called `setBaseAndExtent`, and since Firefox 55 setting
a selection inside an editing host moves focus to it, so it stole focus from the
input: typing "the" in the search-highlighting demo left "t" in the input and
"he" in the editor.

The re-render also replaces the text node holding the stale DOM selection, and
the following `selectionchange` synced it back to the editor selection.

- skip `toNativeSelection` when a text input outside the editor is focused
- skip syncing the DOM selection to the editor in `toSlateSelection` in that
  case, after the existing "not in editor -> deselect" check so Chrome is unchanged

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

423 of 1392 branches covered (30.39%)

Branch coverage included in aggregate %.

12 of 15 new or added lines in 2 files covered. (80.0%)

1146 of 3005 relevant lines covered (38.14%)

23.06 hits per line