worktile / slate-angular / 5172d126-ac49-4598-b4fc-047dcc0ea911

35%

master: 36%

Pull #341

circleci

fix(core): remove obsolete firefox focus compat in toNativeSelection to avoid stealing focus #WIK-20030

The `el.focus()` in Firefox was added for bugzilla 1318312 (2016/11/16), which has been fixed since Firefox 55: the Selection API now moves focus to the editing host synchronously. slate-react also removed the same code in 0.98.0 (ianstormtaylor/slate#5486).

Since it runs in a setTimeout, it steals focus from inputs focused in between (e.g. the input of a newly inserted void/tag), which blurs and closes them.

- revert the activeElement guard and the spec that can't cover the Firefox-only branch in Chrome karma
- add an "insert and focus" toolbar item in the editable-voids demo to verify this scenario in Firefox

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

406 of 1366 branches covered (29.72%)

Branch coverage included in aggregate %.

1131 of 2985 relevant lines covered (37.89%)

22.56 hits per line