radio-t / stream-recorder / 34444138665

76%

master: 76%

Pull #39

github

Recover a chapter whose topic was superseded before its retry

A topic whose article fetch failed stayed pending until the next poll
reported it again. If a different topic became active first, the pending
one was dropped and its chapter never reached the recording, so a single
502 from the article endpoint at the wrong moment still cost a chapter.

The pending topic now gets one last fetch as it is displaced. Its article
is still addressable by id, and its offset is earlier than the incoming
topic's, so recording it there keeps the chapters in ascending order and
no sorting is needed.

That last fetch is skipped when the topic being displaced by is the one
already active, i.e. the previous topic simply came back. Nothing marks
that return, so recording the blip would stretch it across the rest of
that topic's span, which is worse than losing a marker for a topic that
was active for a couple of minutes.

16 of 16 new or added lines in 1 file covered. (100.0%)

1021 of 1346 relevant lines covered (75.85%)

8.54 hits per line