radio-t / stream-recorder / 34444131806

76%

master: 76%

Build Type

Pull #32

github

Committed by paskal

Commit Message

Report zip failures instead of swallowing them

GET /episode/{folder} builds a zip archive per request and every failure
along the way was swallowed: open, stat and entry-creation errors skipped
the file, io.Copy and the source Close were ignored, and the deferred
zip.Writer.Close discarded its error, so a failed read could produce a
complete-looking archive silently missing a file behind an already-sent
200.

Every failure is now returned immediately. A failure before the first
byte reaches the client clears the attachment header and returns 500;
after that the archive is left unfinished on purpose, so without a
central directory the client sees a broken download. Entries carry the
file's modification time, which zip.Writer.Create left at the start of
the DOS epoch.

Pull Request Pull Request #32: Report zip failures instead of swallowing them

Coverage Stats

35 of 42 new or added lines in 1 file covered. (83.33%)

1 existing line in 1 file now uncovered.

1043 of 1369 relevant lines covered (76.19%)

8.33 hits per line