radio-t / stream-recorder / 34444136466

78%

master: 76%

Pull #38

github

Replace the manual-record flag with a session lifecycle

A single atomic.Bool both lost accepted requests and kept unwanted ones.
recordStream cleared it before calling Record, so a failure creating the
output file consumed the request and the error path never restored it. In
the other direction, POST /record was accepted during a recording and,
since the flag survives missing-stream polls, a later broadcast could be
recorded without anyone asking for it.

The new session.Controller holds idle, pending, starting and recording,
with a deadline on a pending request. A request is accepted only from
idle, so the server answers 409 while one is already waiting or running.
A session claims a pending request when it begins and spends it only once
audio has been written, so any failure before that hands the request back
and the next poll retries it, until it expires after 30 minutes.

Recorder.onReady, which drives that transition, now fires on the first
successful audio write rather than after the ID3 header, so the point
where a session becomes a recording is the point where it has produced
something.

The server takes a RecordSession interface in place of the two
atomic.Bool arguments, which changes the exported NewServer signature.

119 of 125 new or added lines in 4 files covered. (95.2%)

1119 of 1436 relevant lines covered (77.92%)

10.8 hits per line