radio-t / stream-recorder / 34444129873

76%

master: 76%

Build Type

Pull #31

github

Committed by paskal

Commit Message

Report and finalise a recording interrupted by a stream failure

Record created the final .mp3 up front and then returned an empty path on
any non-cancellation failure. The partial file stayed on disk and the
server listed it for download, while the caller had no path for it, so it
was published without TLEN, chapters or a VBR header, and the log never
named it.

Record now reports whether audio reached the disk, and that alone decides
what happens to the file. A session that captured audio returns its path
alongside the error, and recordStream logs it and runs the same
post-processing a completed recording gets. A session that captured none
is removed along with its episode directory, whether the header write
failed, the stream ended straight away, or a cancellation landed before
the first audio byte: a file holding only an ID3 header is not a
recording and must not be served.

The streaming loop moved into streamToFile, which keeps Record within the
complexity limits after the extra branches.

Pull Request Pull Request #31: Report and finalise a recording interrupted by a stream failure

Coverage Stats

45 of 54 new or added lines in 2 files covered. (83.33%)

1 existing line in 1 file now uncovered.

1043 of 1366 relevant lines covered (76.35%)

8.52 hits per line