nats-io / java-nats-server-runner / 34419291189

86%

push

github

JsConfig store dir handling, and connect validation fixes (#47)

JsConfig now takes responsibility for the path it is handed rather than
passing it through untouched. storeDir is the directory that will be used,
fixedDir is the escaped form the config file gets, and inStoreDir keeps an
untouched reference to whatever was supplied. fixDir and cleanDir move to
NatsRunnerUtils as public helpers.

- cleanDir undoes caller escaping, so a path someone escaped themselves is
  not escaped a second time. A leading \\ is kept as a UNC prefix rather
  than collapsed to \, which would name a different location.
- The store dir separator is found after the store_dir key instead of
  anywhere in the line, so a Windows drive letter is no longer eaten by the
  colon in "C:".
- A store dir containing a space is rejected. The conf parser ends an
  unquoted value at the space, so such a directory could never have started
  a server; this replaces a parse error from nats-server with an
  IllegalArgumentException naming the path.
- Connect validation retries again. The loop was dropped in "Improving
  defaults" and has shipped since 3.0.2, so one attempt was made and any
  failure discarded, which is also why testTlsFirst passed without ever
  connecting. Retries cover ConnectException and SocketTimeoutException;
  anything else surfaces immediately rather than after three sleeps.
- isServerReachable connects to loopback instead of 0.0.0.0. That is a bind
  address, not a connect address, and cannot reach a server whose config
  pins net: to an interface.

87 tests pass on Windows and on Linux.


Claude-Session: https://claude.ai/code/session_01YRbGPiFEXpwnU9BEy8mXb7

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

230 of 292 branches covered (78.77%)

Branch coverage included in aggregate %.

684 of 770 relevant lines covered (88.83%)

3.69 hits per line