solidjs / solid / 34398511438

72%

main: 89%

push

github

fix(store): deep() hears base and optimistic writes through chained views; stable row identity under overlays (#3323)

deep() over a derived view (createOptimisticStore(base), projections whose
backing is another store) never re-ran on base writes: the view's targets
chain to the inner store's proxies, base writes bump the INNER record's
witnesses, and the walk subscribed only the outer ones — while resolving
children to fresh non-chained wrappers of the base raw. The walk now reads
through the whole chain and resolves children to the targets the get trap
serves.

Investigating that surfaced two more holes in the same composition:

- deep() over any optimistic store was deaf to every write on a row added
  under a held action: the row lives in presence/value overrides, and the
  walk enumerated the raw backing. The ownKeys/getOwnPropertyDescriptor
  trap bodies are now shared helpers (visibleKeys/visibleDescriptor) the
  walk uses, so parity with readers is structural.
- A derived view's untouched rows came back as fresh proxies for the life of
  an optimistic action and snapped back at settle. notifyOptimisticWrites
  compared the inner store's child PROXIES to the draft's raws and marked
  every row changed; it now compares unwrapped values. Chained targets
  serving from a pending backing resolve inner-owned raws to the inner
  proxy before wrapping (resolveChainedRaw), and snapshotWalk starts from
  the family's wrapper when entering a level from a raw so outer overrides
  below the root compose.

The dist-artifacts top-level-await scanner now skips comments; an apostrophe
in a module-scope docblock opened a phantom string and derailed its depth.

Closes #3323

Co-authored-by: Cursor <cursoragent@cursor.com>

518 of 788 branches covered (65.74%)

Branch coverage included in aggregate %.

771 of 1006 relevant lines covered (76.64%)

14.99 hits per line