solidjs / solid / 34392405287

72%

main: 89%

push

github

fix(signals): preserve transactions entered during finalization; effects follow ownership (#3319)

An ambient flush can enter a held transaction while finalizing (store
commit hook, boundary check, or a stamped recompute) and then kept
committing state and applying effects as though it still owned the
batch, leaving the UI stale once the transaction settled.

finalizePureQueue captures the batch it started with and settles nothing
an entered transaction adopted; a completing transaction whose ambient
batch was separate still settles its own containers. Effects follow the
#3322 owner stamp: in a flush whose finalize entered a transaction,
runEffect leaves runs owned by a still-held transaction queued for the
next gate to park, and applies everything computed mainline — the write
that caused the flush reads and renders together. Lanes are exempt by
construction (they never enter the ordinary queue).

The finalize guard and the two regression tests come from PR #3319 by
DerpyCrabs; the whole-flush park it proposed is replaced with per-effect
ownership, which the two added tests distinguish.

Closes #3319

Co-authored-by: DerpyCrabs <derpycrabs@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

518 of 788 branches covered (65.74%)

Branch coverage included in aggregate %.

771 of 1006 relevant lines covered (76.64%)

14.99 hits per line