dblock / distance_of_time_in_words / 34356848137

99%

push

github

Fix #162: distinguish different TimeWithZone-derived Time zone objects

same_clock? assumed any plain Time with a non-nil, non-UTC #zone was tied
to the process's system zone, since a plain Time's #zone is normally
either nil (fixed numeric offset) or a String abbreviation (system TZ).
On Rails >= 8.0, however, converting an ActiveSupport::TimeWithZone via
#to_time can return a Time whose #zone is instead the ActiveSupport::
TimeZone object itself. Two such times built from *different* zones were
indistinguishable from two same-system-zone times, so offset_delta still
folded in their unrelated offset difference (#162).

When #zone is not a String, compare the zone objects for equality instead
of just checking presence - two Time values only share a clock if they
carry the very same zone object (by ActiveSupport::TimeZone#== identity),
not merely a non-nil one.

Added a regression spec constructing two Time values from different
named zones via ActiveSupport::TimeZone#local/#to_time (portable across
the whole supported Ruby/Rails matrix, unlike Ruby's Time.new(in:)
keyword which requires Ruby 3.2+).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

280 of 280 relevant lines covered (100.0%)

629.24 hits per line